feat(codeguruprofiler): ProfilingGroup #7895

SeekerWing · 2020-05-10T03:27:36Z

fixes #6984 by creating L2 construct and functions to allow for policies to be assigned to execution roles.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation · 2020-05-10T04:12:45Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: fa7a3e3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-05-10T04:55:07Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 6ce569d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb

Looks pretty solid. See minor comments.

eladb · 2020-05-18T12:40:53Z

packages/@aws-cdk/aws-codeguruprofiler/lib/profiling-group.ts

+  /**
+   * A name for the profiling group.
+   */
+  readonly profilingGroupName: string;


Can this be omitted? Can we produce a sensible default here?

i've changed the approach to the following, not an expert by any means, let me know your thoughts.

physicalName: props.profilingGroupName || Lazy.stringValue({ produce: () => this.node.uniqueId })

packages/@aws-cdk/aws-codeguruprofiler/lib/profiling-group.ts

eladb · 2020-05-18T12:42:47Z

packages/@aws-cdk/aws-codeguruprofiler/README.md

@@ -9,8 +9,28 @@
 ---
 <!--END STABILITY BANNER-->

-This module is part of the [AWS Cloud Development Kit](https://github.com/aws/aws-cdk) project.
+Amazon CodeGuru Profiler collects runtime performance data from your live applications, and provides recommendations that can help you fine-tune your application performance. Using machine learning algorithms, CodeGuru Profiler can help you find your most expensive lines of code and suggest ways you can improve efficiency and remove CPU bottlenecks. Amazon CodeGuru Profiler provides different visualizations of profiling data to help you identify what code is running on the CPU, see how much time is consumed, and suggest ways to reduce CPU utilization.


limit to 100 chars

reduced to 2 sentences, hope that's okay.

Pull request has been modified.

aws-cdk-automation · 2020-05-19T14:01:18Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 4d960d6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-codeguruprofiler/README.md

packages/@aws-cdk/aws-codeguruprofiler/lib/profiling-group.ts

packages/@aws-cdk/aws-codeguruprofiler/package.json

Pull request has been modified.

aws-cdk-automation · 2020-05-19T16:59:58Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: c2b160b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-05-19T17:10:12Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: af0b940
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-05-19T17:15:27Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: ddaa37b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-codeguruprofiler/test/integ.profiler-group.ts

packages/@aws-cdk/aws-codeguruprofiler/test/profiling-group.test.ts

packages/@aws-cdk/aws-codeguruprofiler/lib/profiling-group-base.ts

packages/@aws-cdk/aws-codeguruprofiler/README.md

eladb · 2020-05-20T08:55:44Z

packages/@aws-cdk/aws-codeguruprofiler/lib/profiling-group.ts

+
+  constructor(scope: Construct, id: string, props: ProfilingGroupProps) {
+    super(scope, id, {
+      physicalName: props.profilingGroupName || Lazy.stringValue({ produce: () => this.node.uniqueId }),


Suggested change

physicalName: props.profilingGroupName || Lazy.stringValue({ produce: () => this.node.uniqueId }),

physicalName: props.profilingGroupName ?? Lazy.stringValue({ produce: () => this.node.uniqueId }),

Also - are there any constraints on the profile group name that we should take into account when using unqiueId?

packages/@aws-cdk/aws-codeguruprofiler/test/integ.profiler-group.ts

Pull request has been modified.

aws-cdk-automation · 2020-05-20T17:18:32Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 386195c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-05-21T06:50:50Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 5c4fea5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…nd setup functions to add publish/read policies to IGrantable

Pull request has been modified.

aws-cdk-automation · 2020-05-22T09:04:30Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 505db82
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-05-26T05:25:02Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2020-05-26T06:13:58Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2020-05-26T06:14:09Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: f5fc469
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

L2 constructs were introduced in #7895 about 5 months ago. We missed marking the module as experimental. Updated stability and updated the banner in the README.

) L2 constructs were introduced in #7895 about 5 months ago. We missed marking the module as experimental. Updated stability and updated the banner in the README. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

SomayaB assigned eladb May 11, 2020

eladb previously requested changes May 18, 2020

View reviewed changes

eladb reviewed May 18, 2020

View reviewed changes

eladb changed the title ~~feat(codeguruprofiler): setup L2 construct to create profiler group and setup functions to add publish/read policies to IGrantable~~ feat(codeguruprofiler): ProfilingGroup May 18, 2020

eladb previously requested changes May 19, 2020

View reviewed changes

packages/@aws-cdk/aws-codeguruprofiler/README.md Show resolved Hide resolved

packages/@aws-cdk/aws-codeguruprofiler/lib/profiling-group.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-codeguruprofiler/package.json Outdated Show resolved Hide resolved

SeekerWing force-pushed the code_guru branch from 4d960d6 to c2b160b Compare May 19, 2020 16:12

SeekerWing requested a review from eladb May 20, 2020 05:03

eladb previously requested changes May 20, 2020

View reviewed changes

SeekerWing force-pushed the code_guru branch from 386195c to 5c4fea5 Compare May 21, 2020 06:43

eladb previously approved these changes May 21, 2020

View reviewed changes

SeekerWing added 9 commits May 22, 2020 11:59

feat(codeguruprofiler): setup L2 construct to create profiler group a…

095c8c5

…nd setup functions to add publish/read policies to IGrantable

feat(codeguruprofiler): setup L2 construct to create profiler group a…

f24fae9

…nd setup functions to add publish/read policies to IGrantable

feat(codeguruprofiler): setup L2 construct to create profiler group a…

cc3dbce

…nd setup functions to add publish/read policies to IGrantable

feat(codeguruprofiler): setup L2 construct to create profiler group a…

244dfbd

…nd setup functions to add publish/read policies to IGrantable

feat(codeguruprofiler): setup L2 construct to create profiler group a…

287ad66

…nd setup functions to add publish/read policies to IGrantable

feat(codeguruprofiler): setup L2 construct to create profiler group a…

8823098

…nd setup functions to add publish/read policies to IGrantable

feat(codeguruprofiler): setup L2 construct to create profiler group a…

6136129

…nd setup functions to add publish/read policies to IGrantable

feat(codeguruprofiler): setup L2 construct to create profiler group a…

cd5f5f4

…nd setup functions to add publish/read policies to IGrantable

feat(codeguruprofiler): setup L2 construct to create profiler group a…

505db82

…nd setup functions to add publish/read policies to IGrantable

SeekerWing force-pushed the code_guru branch from 5c4fea5 to 505db82 Compare May 22, 2020 08:15

SeekerWing requested a review from eladb May 22, 2020 15:53

eladb approved these changes May 26, 2020

View reviewed changes

Merge branch 'master' into code_guru

f5fc469

mergify bot merged commit 995088a into aws:master May 26, 2020

shivlaks mentioned this pull request Oct 14, 2020

chore(codeguruprofiler): update module stability to experimental #10870

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(codeguruprofiler): ProfilingGroup #7895

feat(codeguruprofiler): ProfilingGroup #7895

SeekerWing commented May 10, 2020

aws-cdk-automation commented May 10, 2020

aws-cdk-automation commented May 10, 2020

eladb left a comment

eladb May 18, 2020

SeekerWing May 19, 2020

eladb May 18, 2020

SeekerWing May 19, 2020

aws-cdk-automation commented May 19, 2020

aws-cdk-automation commented May 19, 2020

aws-cdk-automation commented May 19, 2020

aws-cdk-automation commented May 19, 2020

eladb May 20, 2020

eladb May 20, 2020

aws-cdk-automation commented May 20, 2020

aws-cdk-automation commented May 21, 2020

aws-cdk-automation commented May 22, 2020

mergify bot commented May 26, 2020

mergify bot commented May 26, 2020

aws-cdk-automation commented May 26, 2020

	physicalName: props.profilingGroupName \|\| Lazy.stringValue({ produce: () => this.node.uniqueId }),
	physicalName: props.profilingGroupName ?? Lazy.stringValue({ produce: () => this.node.uniqueId }),

feat(codeguruprofiler): ProfilingGroup #7895

feat(codeguruprofiler): ProfilingGroup #7895

Conversation

SeekerWing commented May 10, 2020

aws-cdk-automation commented May 10, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 10, 2020

AWS CodeBuild CI Report

eladb left a comment

Choose a reason for hiding this comment

eladb May 18, 2020

Choose a reason for hiding this comment

SeekerWing May 19, 2020

Choose a reason for hiding this comment

eladb May 18, 2020

Choose a reason for hiding this comment

SeekerWing May 19, 2020

Choose a reason for hiding this comment

aws-cdk-automation commented May 19, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 19, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 19, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 19, 2020

AWS CodeBuild CI Report

eladb May 20, 2020

Choose a reason for hiding this comment

eladb May 20, 2020

Choose a reason for hiding this comment

aws-cdk-automation commented May 20, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 21, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 22, 2020

AWS CodeBuild CI Report

mergify bot commented May 26, 2020

mergify bot commented May 26, 2020

aws-cdk-automation commented May 26, 2020

AWS CodeBuild CI Report